Skip to content

Commit 8e57362

Browse files
gloursndeloof
authored andcommitted
use errdefs.IsNotImplemented to check if the logging is not implemented
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
1 parent 29630f1 commit 8e57362

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

pkg/compose/logs.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,11 @@ package compose
1818

1919
import (
2020
"context"
21-
"errors"
2221
"io"
2322
"time"
2423

24+
"github.com/containerd/errdefs"
2525
"github.com/docker/docker/api/types/container"
26-
"github.com/docker/docker/errdefs"
2726
"github.com/docker/docker/pkg/stdcopy"
2827
"github.com/sirupsen/logrus"
2928
"golang.org/x/sync/errgroup"
@@ -64,8 +63,7 @@ func (s *composeService) Logs(
6463
for _, ctr := range containers {
6564
eg.Go(func() error {
6665
err := s.logContainers(ctx, consumer, ctr, options)
67-
var notImplErr errdefs.ErrNotImplemented
68-
if errors.As(err, &notImplErr) {
66+
if errdefs.IsNotImplemented(err) {
6967
logrus.Warnf("Can't retrieve logs for %q: %s", getCanonicalContainerName(ctr), err.Error())
7068
return nil
7169
}
@@ -106,8 +104,7 @@ func (s *composeService) Logs(
106104
Tail: options.Tail,
107105
Timestamps: options.Timestamps,
108106
})
109-
var notImplErr errdefs.ErrNotImplemented
110-
if errors.As(err, &notImplErr) {
107+
if errdefs.IsNotImplemented(err) {
111108
// ignore
112109
return nil
113110
}

0 commit comments

Comments
 (0)