don't create services passed as parameters of run command during dependencies creation process #12968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Jun 23, 2025
glours
force-pushed
the
fix-run-rm-issue
branch
2 times, most recently
from
8c6f916 to
85a281c
Compare
ndeloof
reviewed
Jun 24, 2025
pkg/e2e/compose_run_test.go
Outdated
|
|
||
| res = c.RunDockerCmd(t, "stop", containerID) | ||
| res.Assert(t, icmd.Success) | ||
| res = c.RunDockerCmd(t, "ps", "--all", "--filter", "name=run-test-nginx") |
There was a problem hiding this comment.
suggestion: use --format '{{.Names}}' in command so output only shows container(s) name
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
changed the title
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jun 25, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.37.2` -> `v2.37.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.37.3`](https://github.com/docker/compose/releases/tag/v2.37.3) [Compare Source](docker/compose@v2.37.2...v2.37.3) #### What's Changed ##### ✨ Improvements - add support for cache\_to with bake by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12959 ##### 🐛 Fixes - fix bake intergation by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12960 - don't create services passed as parameters of run command during dependencies creation process by [@​glours](https://github.com/glours) in docker/compose#12968 - inject secrets/config just before container is started by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12970 - propagate target docker host set by --host to Bake by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12961 ##### 🔧 Internal - pkg/compose: remove uses of ExecOptions.Detach by [@​thaJeztah](https://github.com/thaJeztah) in docker/compose#12950 ##### ⚙️ Dependencies - build(deps): bump github.com/moby/buildkit from 0.23.0 to 0.23.1 by [@​dependabot](https://github.com/dependabot) in docker/compose#12964 **Full Changelog**: docker/compose@v2.37.2...v2.37.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Remove services passed as parameters of the
docker compose runcommand from being created during the dependencies starting processRelated issue
Fix #12965 #12966
(not mandatory) A picture of a cute animal, if possible in relation to what you did
