fix(compose): make sure any flags defined for compose up also exist for compose down #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or compose down When compose calls the model provider, the same arguments are passed to both compose up and compose down. Unless compose down supports any flag supported by compose up, some of these flags will cause a parsing error and cause compose down to fail. To fix this, move the flag setup to a dedicated type and function that can be shared by both commands. Signed-off-by: Alberto Garcia Hierro <damaso.hierro@docker.com>
fiam
force-pushed
the
alberto/fix-missing-flags
branch
from
2e43517 to
0bf514a
Compare
|
Have you encountered an issue wrt this change @fiam? I've been told that ⬇️ .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compose calls the model provider, the same arguments are passed to both compose
up and compose down. Unless compose down supports any flag supported by compose up, some
of these flags will cause a parsing error and cause compose down to fail.
To fix this, move the flag setup to a dedicated type and function that can be shared
by both commands.
Signed-off-by: Alberto Garcia Hierro damaso.hierro@docker.com