Merge service and runtime logs #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilopezluna
approved these changes
May 23, 2025
The `logs` command should include both service, and runtime (engine) logs, to provide all relevant info needed to debug/observe DMR operation. Currently the runtime logs will only be included when running `logs` with `-f` (follow). So make sure the service and runtime logs are merged, and printed, unless `logs` is invoked with `--no-engines`. Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
logscommand should include both service, and runtime (engine)logs, to provide all relevant info needed to debug/observe DMR
operation. Currently the runtime logs will only be included when running
logswith-f(follow). So make sure the service and runtime logs aremerged, and printed, unless
logsis invoked with--no-engines.