Skip to content

Create home folder #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

Create home folder #85

merged 2 commits into from
Jun 16, 2025
+1 −1

Conversation

ilopezluna
Copy link
Contributor

No description provided.

@ilopezluna ilopezluna requested a review from a team June 16, 2025 14:09
p1-0tr
p1-0tr approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@p1-0tr p1-0tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doringeman
Copy link
Contributor

Should we change the default MODELS_PATH as well?

@xenoscopic
Copy link
Collaborator

I'd opt to keep the current MODELS_PATH just because it makes for a simpler syntax for end-users using -v.

@ilopezluna ilopezluna merged commit 64153a7 into main Jun 16, 2025
4 checks passed
@ilopezluna ilopezluna deleted the create-home-folder branch June 16, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenoscopic xenoscopic

@p1-0tr p1-0tr

@doringeman doringeman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilopezluna @doringeman @xenoscopic @p1-0tr