Include the Dockerfile Language Server in the extension #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Users may install the Docker DX extension expecting to get editing features for Dockerfiles. However, we do not currently provide any editing features for Dockerfiles as the Docker Language Server only adds linting support for Dockerfiles.
Proposed Solution
The Dockerfile Language Server provides features that the Docker Language Server does not provide so bundling it in the extension will improve the overall editing experience of Dockerfiles.
If Microsoft's Docker extension or the Container Tools extension is installed, the Dockerfile Language Server will not be started. This is because Microsoft's extensions already include the Dockerfile Language Server. If we also started the Dockerfile Language Server on our side then users may get duplicated information which we want to avoid.
Proof of Work
I confirm that I've tested the extension in a few different cases in the debugger.