Should we add System.Threading.AccessControl to the base shared framework

[ericstj]

It's been part of WindowsDesktop since the beginning. With #110416 it was added to AspNetCore.

Most other *AccessControl libraries in the base shared frammework:
System.IO.FileSystem.AccessControl
System.IO.Pipes.AccessControl
System.Security.AccessControl

Seems like we should just add it. Thoughts @bartonjs @JeremyKuhne?

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

[JeremyKuhne]

@ericstj Seems like a sensible simplification.

[ericstj]

@ViktorHofer - I started looking at this and was thinking the following.

1. Add the library to the base shared framework. Remove from aspnetcore and windows desktop.
2. Remove package references to it when targeting .NET 10.0.
3. Don't yet remove the package, since we're still building other packages which will depend on a supported implementation for older frameworks (net8.0, net9.0).
4. First thing in .NET 11 stop producing the package.

Does this sound right? I don't think we can remove the package now and reference the 9.0 version since that might go out of support before other frameworks and it carries an implementation for net8 and net9.

[ViktorHofer]

I'm supportive of this change. It will reduce necessary package downloads when using the base shared framework and depending on the library's API set. It will also simplify our own infrastructure (it's one of those packages that use a TPM with the PNSE infrastructure that hinders switching to compiler generated XML).

I started looking at this and was thinking the following.

Sounds right to me. Note that the PackageOverrides.txt data is still not auto-generated so you probably want to add that to the above list. Let's remove the package with .NET 11 then 👍

[bartonjs]

Moving them into the core shared runtime seems fine. When .NET EvenCorer happens in another 5-10 years maybe we'll undo this layering change and just accept the PNSEs on non-Windows 😄

[ericstj]

We already accept PNSEs, you mean removing all the extensions and putting back the API on the original types?