-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Adding debugger step-through attributes to static helpers #116935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds debugging attributes to internal methods to improve debugger stepping behavior by automatically hiding and stepping through them.
- Applies
[DebuggerHidden]
and[DebuggerStepThrough]
to thread-local and runtime helper methods. - Affects CoreCLR threading and runtime compiler services code.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs | Added debugger attributes to GetThreadStaticsBase |
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs | Added debugger attributes to several helper methods |
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
@dotnet-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on your first runtime PR!
#116671 is the WASM failure |
#110709