Skip to content

Adding debugger step-through attributes to static helpers #116935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025
Merged

Adding debugger step-through attributes to static helpers #116935

merged 4 commits into from
Jun 24, 2025

Conversation

rcj1
Copy link
Contributor

@rcj1 rcj1 commented Jun 23, 2025

@Copilot Copilot AI review requested due to automatic review settings June 23, 2025 22:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds debugging attributes to internal methods to improve debugger stepping behavior by automatically hiding and stepping through them.

  • Applies [DebuggerHidden] and [DebuggerStepThrough] to thread-local and runtime helper methods.
  • Affects CoreCLR threading and runtime compiler services code.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs Added debugger attributes to GetThreadStaticsBase
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Added debugger attributes to several helper methods

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 23, 2025
@rcj1 rcj1 added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 23, 2025
Copy link
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

@rcj1
Copy link
Contributor Author

rcj1 commented Jun 23, 2025

@rcj1 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree company="Microsoft"

@rcj1 rcj1 requested a review from steveisok June 23, 2025 22:10
@hoyosjs hoyosjs added this to the 10.0.0 milestone Jun 23, 2025
@hoyosjs hoyosjs linked an issue Jun 23, 2025 that may be closed by this pull request
@rcj1 rcj1 enabled auto-merge (squash) June 23, 2025 22:53
rcj1 added 2 commits June 23, 2025 15:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first runtime PR!

@hoyosjs hoyosjs changed the title adding debugger attributes Adding debugger step-through attributes to static helpers Jun 23, 2025
@hoyosjs
Copy link
Member

hoyosjs commented Jun 23, 2025

#116671 is the WASM failure

@rcj1 rcj1 merged commit ad13be0 into main Jun 24, 2025
93 of 95 checks passed
@hoyosjs hoyosjs deleted the gh110709 branch June 24, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepping Into Statics Helper Code
3 participants