[release/8.0-staging] Fix return in zlib-intel when window allocation fails #116550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
If a process is running low on memory and fails window allocation in zlib on Windows, we weren't correctly returning the error to produce the correct ZlibException. This creates a reliability issue as the failure looks like an application crash instead of out of memory. This issue is unique to the zlib-intel codebase.
Regression
Testing
Unit tests, adhoc testing.
Risk
Low. This is likely a non-recoverable error, we're just making sure we surface in a way that diagnostics will correctly capture.