Skip to content

Add deduplication info to OneFuzz fuzzing crash work items #116615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

MihaZupan
Copy link
Member

OneFuzz seems to have changed defaults and I'm now getting spammed with duplicate reports.
This change attempts to dedup reports based on the crash stack trace.

@MihaZupan MihaZupan added this to the 10.0.0 milestone Jun 13, 2025
@MihaZupan MihaZupan self-assigned this Jun 13, 2025
@Copilot Copilot AI review requested due to automatic review settings June 13, 2025 01:52
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 13, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds deduplication information to OneFuzz fuzzing crash work items by updating the JSON configuration generation in the DotnetFuzzing program.

  • Updated string interpolation syntax to accommodate additional JSON fields.
  • Introduced new deduplication configuration fields (AdoFields, UniqueFields, OnDuplicate) to assist in deduping reports based on crash stack traces.
Comments suppressed due to low confidence (2)

src/libraries/Fuzzing/DotnetFuzzing/Program.cs:339

  • New deduplication fields have been introduced; please add tests to ensure the generated JSON output contains the expected deduplication configuration and that duplicate reports are handled as intended.
+                    "AdoFields": {

src/libraries/Fuzzing/DotnetFuzzing/Program.cs:301

  • Verify that the additional '$' in the raw string literal is intentional and produces the correct interpolation behavior as expected for the JSON configuration format.
+            $$$"""

@karelz karelz removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 13, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@MihaZupan MihaZupan merged commit 7747825 into dotnet:main Jun 13, 2025
87 of 89 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants