Avoid CORINFO_..._HANDLEs in JIT helper signatures

[jkotas]

CORINFO_..._HANDLEs are meant to be JIT/EE interface abstraction. Using them in JIT helper signatures causes confusion.

[Copilot]

Pull Request Overview

This pull request updates several JIT helper signatures and related functions to avoid using CORINFO_..._HANDLE types in favor of more explicit type‐safe parameters. Key changes include:

• Removing and replacing the use of CORINFO_MODULE_HANDLE and CORINFO_CLASS_HANDLE with Module*, EnregisteredTypeHandle, or equivalent types.
• Updating return types and parameter types of functions such as GenericHandleWorkerCore, JIT_GetClassFromMethodParam, and GenericHandleCommon.
• Adjusting helper functions in both core JIT interface and interpreter implementations to ensure consistency with the new type usage.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/jitinterface.h	Removal of ConstructStringLiteral declaration to avoid exposing CORINFO_ handles.
src/coreclr/vm/jitinterface.cpp	Local variable rename and direct use of Module::ResolveStringRef for clarity.
src/coreclr/vm/jithelpers.cpp	Function signatures updated to replace CORINFO_ handles with EnregisteredTypeHandle and MethodDesc*.
src/coreclr/vm/interpexec.cpp	Updated type conversions and function signatures to reflect new handle types.
src/coreclr/vm/appdomainnative.hpp/.cpp	Adjusted the String_StrCns API to use Module* consistently.

Comments suppressed due to low confidence (6)

src/coreclr/vm/jitinterface.h:1029

• The removal of ConstructStringLiteral from the public header is consistent with avoiding CORINFO_ handles; ensure that all internal references now use the updated approach.

STRINGREF* ConstructStringLiteral(CORINFO_MODULE_HANDLE scopeHnd, mdToken metaTok, void** ppPinnedString = nullptr);

src/coreclr/vm/jitinterface.cpp:12082

• The change to use Module::ResolveStringRef directly (with the renamed pPinnedString) aligns with the PR's goal; please verify that all internal usages are consistent.

STRINGREF* ptr = ((Module*)scopeHnd)->ResolveStringRef(metaTok, &pPinnedString);

src/coreclr/vm/jithelpers.cpp:540

• Changing the return type from CORINFO_GENERIC_HANDLE to DictionaryEntry should be verified against all call sites to ensure that the new type is handled correctly.

DictionaryEntry GenericHandleWorkerCore(MethodDesc * pMD, MethodTable * pMT, LPVOID signature, DWORD dictionaryIndexAndSlot, Module* pModule)

src/coreclr/vm/jithelpers.cpp:767

• Updating JIT_GetClassFromMethodParam to accept a MethodDesc* parameter instead of a CORINFO_METHOD_HANDLE is in line with eliminating CORINFO_ handles; please ensure this change is compatible with all callers.

HCIMPL1(EnregisteredTypeHandle, JIT_GetClassFromMethodParam, MethodDesc* pMD)

src/coreclr/vm/interpexec.cpp:136

• Changing GenericHandleCommon's return type from CORINFO_GENERIC_HANDLE to void* requires verification that all usages correctly handle the new return type.

void* GenericHandleCommon(MethodDesc * pMD, MethodTable * pMT, LPVOID signature)

src/coreclr/vm/appdomainnative.hpp:19

• Updating the parameter of String_StrCns to accept a Module* instead of a CORINFO_MODULE_HANDLE fulfills the PR goal; confirm that all invocations pass a valid Module pointer.

extern "C" STRINGREF* QCALLTYPE String_StrCns(UINT32 rid, Module* pModule);

[dotnet-policy-service]

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

[jkotas]

Unnecessary wrapper

[kg]

comment outdated now

[janvorli]

LGTM, thank you!