Skip to content

Normalize immidates in arm32 add/sub #116711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Conversation

MichalPetryka
Copy link
Contributor

ARM64 normalizes them like this and afair ARM32 takes immidates as unsigned so not having this forces using a register.

ARM64 normalizes them like this and afair ARM32 takes immidates as unsigned so not having this forces using a register.
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 16, 2025
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 16, 2025
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT
Copy link
Member

@a74nh, @amanasifkhalid, please review this community PR.

Copy link
Contributor

@a74nh a74nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Change is identical to the existing code in codegenarm64.cpp.

@amanasifkhalid
Copy link
Member

/ba-g test dead-lettered on unrelated platform

@amanasifkhalid amanasifkhalid merged commit f1f9934 into dotnet:main Jul 14, 2025
109 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants