[cDAC] X86 support FuncEvalFrame #116796
Merged
[cDAC] X86 support FuncEvalFrame #116796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds X86 support for function evaluation frames by updating interface method implementations and introducing a new method to handle function evaluation scenarios.
- Changed explicit interface implementations for handling faulting exception and hijack frames to public methods.
- Added the public override method HandleFuncEvalFrame to update the register context during function evaluation.
...iagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/X86FrameHandler.cs
Show resolved
Hide resolved
9 tasks
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
max-charlamb
requested review from
steveisok,
jkotas,
davidwrighton,
tommcdon,
hoyosjs and
mangod9
filipnavara
approved these changes
Jun 18, 2025
mangod9
approved these changes
Jun 18, 2025
This was referenced Jun 19, 2025
This was referenced Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #114019
Verified using VS to debug a dotnet program and hang the immediate evaluation with
Console.Read(). Useddotnet-dumpto collect a dump of the debugged process with a[FuncEvalFrame]on the stack.