Remove BalsaParser runtime flag. #40134
Conversation
Signed-off-by: Paul Ogilby <pgal@google.com>
paul-r-gall
requested review from
mattklein123,
yanavlasov,
wbpcode and
tyxia
as code owners
|
CC @envoyproxy/runtime-guard-changes: FYI only for changes made to |
|
/assign @ggreenway |
| TEST_P(Http1ClientConnectionImplTest, | ||
| ShouldDumpParsedAndPartialHeadersWithoutAllocatingMemoryIfProcessingHeaders) { | ||
| if (parser_impl_ == Http1ParserImpl::BalsaParser) { | ||
| // TODO(#21245): Re-enable this test for BalsaParser. |
There was a problem hiding this comment.
Should this test be kept to keep the TODO?
There was a problem hiding this comment.
Done. Realized that the memory allocation part was totally fine, but the information dumped is a little off.
Signed-off-by: Paul Ogilby <pgal@google.com>
Signed-off-by: Paul Ogilby <pgal@google.com>
Signed-off-by: Paul Ogilby <pgal@google.com>
Signed-off-by: Paul Ogilby <pgal@google.com>
|
/lgtm api |
Signed-off-by: Paul Ogilby <pgal@google.com>
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
Signed-off-by: Paul Ogilby <pgal@google.com>
|
Looks like it needs a format update |
|
LGTM. Will wait for CI to become green. /wait |
Signed-off-by: Paul Ogilby <pgal@google.com>
Signed-off-by: Paul Ogilby <pgal@google.com>
|
/retest |
| @@ -11,6 +11,8 @@ directories: | |||
| source/common/crypto: 95.5 | |||
| source/common/event: 98.3 # Emulated edge events guards don't report LCOV | |||
| source/common/filesystem/posix: 96.4 # FileReadToEndNotReadable fails in some env; createPath can't test all failure branches. | |||
| source/common/http: 96.5 | |||
| source/common/http/http1: 93.4 # To be Femoved when http_inspector_use_balsa_parser is retired. | |||
There was a problem hiding this comment.
We should fix, but I want to get this merged before release.
Commit Message: Remove BalsaParser/HttpParser runtime flag.
Additional Description: Removes the option to use HttpParser instead of BalsaParser
Risk Level: Low; Balsa parser has been the default for a significant amount of time.
Testing: unit, integration