Skip to content

Add agent command for reporting metrics #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2025
Merged

Add agent command for reporting metrics #8

merged 6 commits into from
Feb 21, 2025

Conversation

stympy
Copy link
Member

@stympy stympy commented Feb 14, 2025

I wanted to report metrics from our servers to Insights without using Vector, so I had Claude help me add an agent command that does that. :)

In the future we can have this command also spin up a proxy for relaying notices and events.

Metrics look like this in Insights:

Insights Budgie - Honeybadger

Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that TestAgentCommand only actually runs the agentCommand in the "requires API key" test, but it's just testing reportMetrics directly otherwise. The name of the test implies that it's testing reporting metrics through the agent command. 🤷

@stympy
Copy link
Member Author

stympy commented Feb 15, 2025

@rabidpraxis from a querying/charting standpoint, would it be better to report an event per metric rather than having all the metrics combined in one event? If so, would it be better to report an event per disk vs. having all disks in an array?

@rabidpraxis
Copy link

It should be fine to have all the metrics in the same event.

The array of disks start to get tricky as it can be challenging to filter on a single disk (by name for example) or to do something like get the max bytes of all the disks. Having each one be an event would make it much simpler to work with.

Send individual events for CPU, memory, and each disk
@stympy stympy merged commit 77451ed into main Feb 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants