chore: fixes

Author: subzero10

README.md

@@ -169,10 +169,6 @@ The workflow does the following:
 
 _Note: only users with write permissions can trigger this workflow (i.e. Collaborators)._
 
-## Known bugs
-
-- [ ] Always shows "Honeybadger.HoneybadgerClient" when reporting a notice with a message
-
 ## TODO
 
 - [ ] Publish README with basic info to setup core nuget

examples/Honeybadger.Console/Program.cs

@@ -15,5 +15,5 @@
     .Bind(options);
 
 var client = new HoneybadgerClient(Options.Create(options));
-client.Notify("hello from .Net !");
+client.Notify("Hello from .Net! Improved error handling with Honeybadger.");
 Console.WriteLine("Done. Check your Honeybadger dashboard for the error.");

examples/Honeybadger.Console/appsettings.json

@@ -7,7 +7,7 @@
         }
     },
     "Honeybadger": {
-        "ApiKey": "your_api_key",
+        "ApiKey": "api_key",
         "AppEnvironment": "development",
         "ReportData": true
     }

examples/Honeybadger.DotNetCoreWebApp.Logger/Program.cs

@@ -8,7 +8,7 @@
 app.MapGet("/", () => "Hello World!");
 app.MapGet("/notify", ([FromServices] ILogger<Program> logger) =>
 {
-    logger.LogError("hello from Honeybadger.Logger!");
+    logger.LogError("Hello from Honeybadger.Logger! Improved error handling with Honeybadger.");
 
     return "Log reported to Honeybadger. Check your dashboard!";
 });

examples/Honeybadger.DotNetCoreWebApp.Logger/appsettings.json

@@ -5,7 +5,7 @@
       "Microsoft.AspNetCore": "Warning"
     },
     "Honeybadger": {
-      "ApiKey": "your_api_key",
+      "ApiKey": "api_key",
       "AppEnvironment": "development",
       "ReportData": true
     }

examples/Honeybadger.DotNetCoreWebApp/Program.cs

@@ -13,7 +13,7 @@
 });
 app.MapGet("/debug", () =>
 {
-    throw new Exception("hello from .Net Core Web App!");
+    throw new Exception("Hello from .Net Core Web App! Improved error handling with Honeybadger.");
 });
 
 app.Run();

examples/Honeybadger.DotNetCoreWebApp/appsettings.json

@@ -7,7 +7,7 @@
   },
   "AllowedHosts": "*",
   "Honeybadger": {
-    "ApiKey": "your_api_key",
+    "ApiKey": "api_key",
     "AppEnvironment": "development",
     "ReportData": true
   }

src/Honeybadger.DotNetCore/HoneybadgerMiddleware.cs

@@ -18,7 +18,7 @@ public async Task Invoke(HttpContext context, IHoneybadgerClient client)
         // needed for HoneybadgerStartupFilter.cs
         context.Items[HttpContextItemsKey] = client;
 
-        if (client.Options.ShouldReport())
+        if (!client.Options.ShouldReport())
         {
             await _next(context);
             return;

src/Honeybadger.Extensions.Logging/HoneybadgerLogger.cs

@@ -39,11 +39,11 @@ public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Except
             if (exception is null)
             {
                 var notice = formatter(state, exception);
-                _client.Notify(notice);
+                _client.NotifyAsync(notice).ConfigureAwait(false);
             }
             else
             {
-                _client.Notify(exception);
+                _client.NotifyAsync(exception).ConfigureAwait(false);
             }
         }
     }

src/Honeybadger/NoticeHelpers/NoticeFactory.cs

@@ -1,4 +1,5 @@
 using System.Diagnostics;
+using System.Security.Cryptography;
 using Honeybadger.Schema;
 
 namespace Honeybadger.NoticeHelpers;
@@ -16,13 +17,20 @@ public static class NoticeFactory
     public static Notice Make(IHoneybadgerClient client, string message, Dictionary<string, object>? context = null)
     {
         var stackTrace = new StackTrace(1, true);
-        var isFirstFrameInternal =
-            stackTrace.GetFrame(0)?.GetMethod()?.DeclaringType?.FullName?.Contains("HoneybadgerClient");
-        if (isFirstFrameInternal.HasValue && isFirstFrameInternal.Value)
+        // do while loop to skip internal frames
+        var frameIndex = 0;
+        var isFrameInternal = true;
+        while (isFrameInternal)
         {
-            stackTrace = new StackTrace(2, true);
+            isFrameInternal = stackTrace.GetFrame(frameIndex)?
+                .GetMethod()?
+                .DeclaringType?.FullName?
+                .Contains("Honeybadger") ?? false;
+            
+            frameIndex++;
         }
-
+        stackTrace = new StackTrace(frameIndex, true);
+        
         return Make(client, message, stackTrace, context: context);
     }