Skip to content

fix: no longer raise exception in notice class #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

roelbondoc
Copy link
Contributor

This removes the exception raised in the Notice class and fixes the logic for assigning the hash to the exception attribute when an an exception is not present.

Also took the liberty to cleanup the initialization of the class to be a bit clearer.

This removes the exception raised in the Notice class and fixes the
logic for assigning the hash to the exception attribute when an an
exception is not present.
@roelbondoc roelbondoc force-pushed the 206-breaking-change-in-0230-error_message-and-error_class-must-be-provided branch from 1cc9115 to f66837e Compare May 13, 2025 14:33
@roelbondoc roelbondoc merged commit 844278a into master May 13, 2025
35 checks passed
@roelbondoc roelbondoc changed the title feat: no longer raise exception in notice class fix: no longer raise exception in notice class May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in 0.23.0: error_message and error_class must be provided
3 participants