feat(insights): automatic insights instrumentation #215
+1,925
−350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instrumenting ASGI * Add celery events & reworked tests * Django request & db events * Flask request & db instrumentation * ASGI instrumentation * Syntax update * Updated README * Change "component" to "app" for insights event I followed the naming from our notice data. The more common name for this field is "app", so renaming to that. * Remove url & add blueprint to flask events * Removing args from celery event Until we have filtering and before_event functionality. * Add duration to celery events * PR fixes
Also fix config bleeding issue with asgi test
* feat(insights): add config for insights contrib This also reworks our config class to use a root dataclass with nested dataclasses for each `insights_config` option set. * Refactor the missing key error handling * Add ASGI config * README fixes * Add comments back and fixed readme, remove cruft * Log errors Also a nice little refactor on the Configuration internals. * Wrap insights event code in a try * How about some test results * Fix 3.8 object is not subscriptable error * Don't reference private Context * Check code-quality as well
* refactor threadlocals This now uses the ContextVar and a helper ContextStore class. * Basic event_context * More tests * Fix other Notice usage
…t context to celery tasks (#216) * feat(insights) add request_id * Add request_id to notice * Fix test * Fix formatted string * Update honeybadger/contrib/celery.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add logger to celelry * Sanitize request_id from inputs --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a WIP PR to keep track of the work being merged into this preview branch.