fix: create dict for missing exception #222
Merged
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts back to the previous way we dealt with a missing exception
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the behavior for handling missing exceptions, ensuring that an exception dictionary is properly created when no exception is provided. Key changes include:
- Adding a new test case (test_notify_with_error_message_only) to cover scenarios where only an error message is provided.
- Updating the _process_exception logic in notice.py to always create an exception dict containing both error_class and error_message.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| honeybadger/tests/test_core.py | New test verifies payload format when error_message is provided only. |
| honeybadger/notice.py | Adjusted exception processing to revert to prior behavior. |
Comments suppressed due to low confidence (1)
honeybadger/notice.py:22
- Review the updated condition to ensure that always including error_message in context (when an exception exists) is the intended behavior. Clarifying inline documentation for this change could help future maintainers.
if self.exception and self.error_message:
benjaoming
reviewed
Jun 10, 2025
|
|
||
| def test_payload(request): | ||
| payload = json.loads(request.data.decode("utf-8")) | ||
| # This demonstrates the current bug - NoneType class and None message |
There was a problem hiding this comment.
seems like a stray comment?
|
Thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #221
This reverts back to the previous way we dealt with a missing exception.