Skip to content

fix: prepend callback in Active Job plugin #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

douglasshuang
Copy link
Contributor

@douglasshuang douglasshuang commented Mar 21, 2025

Resolves #675

BEGIN_COMMIT_OVERRIDE
fix: prepend callback in Active Job plugin
END_COMMIT_OVERRIDE

@douglasshuang douglasshuang marked this pull request as ready for review March 21, 2025 13:28
Copy link
Contributor

@roelbondoc roelbondoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine! I can't think of any reason why the callback can't be prepended, but I'll ask @stympy for a second pair of eyes jic I'm missing something.

@roelbondoc roelbondoc requested a review from stympy March 21, 2025 14:55
@douglasshuang
Copy link
Contributor Author

@roelbondoc Thank you! I'm sorry about the PR title. Should I try to fix it?

@stympy stympy changed the title Prepend callback in Active Job plugin fix: prepend callback in Active Job plugin Mar 21, 2025
@stympy
Copy link
Member

stympy commented Mar 21, 2025

LGTM

@roelbondoc roelbondoc merged commit a46a668 into honeybadger-io:master Mar 21, 2025
85 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active Job plugin prevents propagating global context set in other before_perform/around_perform callback
3 participants