-
Notifications
You must be signed in to change notification settings - Fork 617
✨ Migrate ssm code to AWS SDK v2 #5529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @miyadav. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
acf1453
to
0082989
Compare
/test ? |
@miyadav: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0082989
to
4b07844
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! I've left a few comments. As Punkaj suggested, review the PRs that have merged before and try to follow their structure.
Clients should go in pkg/cloud/scope/clients.go
and the interfaces should go in pkg/cloud/services/<service name>/service.go
.
a5f6060
to
124624c
Compare
updated , thanks @punkwalker , @nrb . |
124624c
to
6d18363
Compare
…dle in ssm/service as well)
… failed ,updated method signatures for tests to pass
func isErrorRetryable(err error, retryableCodes []string) bool { | ||
// Use the ParseSmithyError utility to parse the error | ||
smithyErr := awserrors.ParseSmithyError(err) | ||
if smithyErr == nil { | ||
return false | ||
} | ||
|
||
// Get the error code from the parsed error | ||
codeToCheck := smithyErr.ErrorCode() | ||
|
||
// Compare the extracted string with your list | ||
for _, code := range retryableCodes { | ||
if codeToCheck == code { | ||
return true // It's a match! | ||
} | ||
} | ||
return false | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @punkwalker , but , I am using ParseSmithyError from the awserrors package in the isErrorRetryable function, my intent was to rely on the centralized logic in ParseSmithyError , let me know if I have misunderstood , your comment.
a01df82
to
9b0502a
Compare
9b0502a
to
ab9a661
Compare
/test pull-cluster-api-provider-aws-e2e-blocking |
/test pull-cluster-api-provider-aws-build-docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 30f2438df768fe37b39adcfe226249799ec0a67c
|
/test pull-cluster-api-provider-aws-build-docker |
4 similar comments
/test pull-cluster-api-provider-aws-build-docker |
/test pull-cluster-api-provider-aws-build-docker |
/test pull-cluster-api-provider-aws-build-docker |
/test pull-cluster-api-provider-aws-build-docker |
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
Migrates ssm code to AWS SDK v2
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5412
Special notes for your reviewer:
Checklist:
squashed commits
includes documentation
includes emoji in title
adds unit tests
adds or updates e2e tests
Release note: