-
Notifications
You must be signed in to change notification settings - Fork 618
🐛 Fix missing CRD validation for Amazon Linux 2023 eksLookupType #5558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix missing CRD validation for Amazon Linux 2023 eksLookupType #5558
Conversation
Hi @AmitSahastra. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 58eeb4bcc46b3fd42f98211e486d9085daedd454
|
/cherrypick release-2.8 |
@richardcase: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold until v1beta1 changes are removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: e734d224f7ee048026406b7cf72f38d8180ba6dd
|
/unhold |
@richardcase: new pull request created: #5566 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
With recent changes introduced to support AL2023 EKS lookup #5517.
This PR fixes the missing CRD changes that prevent users from using the AL2023 feature. While PR #5517 added the AMI lookup logic for Amazon Linux 2023, it missed updating the CRD validation enums, causing validation errors when users try to specify
eksLookupType: "AmazonLinux2023"
.What this PR does / why we need it:
This PR completes the AL2023 support by adding the missing CRD enum values. The original PR #5517 added the backend logic for AL2023 AMI lookup but forgot to update the CRD validation, making the feature unusable. This fix enables users to actually use the AL2023 feature that was intended to be supported.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Fixes the validation error when users try to use
eksLookupType: "AmazonLinux2023"
in their AWSManagedMachinePool specifications.Special notes for your reviewer:
AmazonLinux
andAmazonLinuxGPU
will continue to workChanges made:
EKSOptimizedLookupType
enum in bothapi/v1beta1/types.go
andapi/v1beta2/types.go
to include:AmazonLinux2023
AmazonLinux2023GPU
infrastructure.cluster.x-k8s.io_awsmachinepools.yaml
infrastructure.cluster.x-k8s.io_awsmachines.yaml
infrastructure.cluster.x-k8s.io_awsmachinetemplates.yaml
infrastructure.cluster.x-k8s.io_awsmanagedmachinepools.yaml
Checklist:
Release note: