-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix: append dot to recordName and target as required by RFC 2782 #5534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @frittentheke. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
This change requrie a unit test. Otherwise nothing stopping to change this lines |
Need to fix commit message(s) as well |
According to RFC2782 [1], SRV records are to be fully-qualified, ending with a final dot. Most providers are liberal, but e.g. OpenStack Designate expects the record name and targets to end with a dot ([2]) Fixes kubernetes-sigs#5476 Fixes kubernetes-sigs#5389 Fixes kubernetes-sigs#5343 Fixes inovex/external-dns-openstack-webhook#50 [1] https://datatracker.ietf.org/doc/html/rfc2782 [2] https://github.com/openstack/designate Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
2c494da
to
c819bc1
Compare
What does it do ?
According to RFC2782 [1], SRV records are to be fully-qualified, ending with a final dot. Most providers are liberal, but e.g. OpenStack Designate expects the record name and targets to end with a dot ([2])
[1] https://datatracker.ietf.org/doc/html/rfc2782
[2] https://github.com/openstack/designate/blob/698f7b605926ab26eb1577f8728f77c71e2fbda1/designate/tests/unit/objects/test_rrdata_srv.py
Motivation
Fixes #5476, Fixes #5389, Fixes #5343, Fixes inovex/external-dns-openstack-webhook#50
More