-
Notifications
You must be signed in to change notification settings - Fork 392
frontend: i18n: Add missing translations for UI #3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: i18n: Add missing translations for UI #3387
Conversation
Welcome @SinghaAnirban005! |
32ceb9e
to
400bb38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! 😃
I think the changes to the Filter translations are unrelated to the missing Hindi translations, maybe they could be better separated by the commits. I would suggest the following:
- Separate the commits into (1) filling in missing Hindi translations and (2) the change to NamespacesAutocomplete with all the subsequent filter translations
- Adjust the PR title to reflect the broader scope of the changes (e.g.
frontend: i18n: Add missing translations for UI
)
@skoeva Will update it soon 🚀 |
de4ac3c
to
52cca9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can clarify what I mean by the separation. We can have two commits here:
- One commit for the missing Hindi translations (not including any of the changes to the "Filter" translations):
frontend: i18n: Add missing Hindi translations
- One commit for the "Filter" translations (the NamespacesAutocomplete change as well as the updated translation files): something like
frontend: NamespacesAutocomplete: Translate placeholder text
Be sure to rebase as well to keep the branch up to date
237232f
to
79be572
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixed a conflict rebased against main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume, SinghaAnirban005, skoeva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
This PR adds the missing Hindi translations for several UI components that were previously displaying English text despite the Hindi language being selected. Ensuring complete localization improves accessibility and user experience for Hindi-speaking users.
Fixes #3386
Changes Made
glossary.json
under hindi translationstranslation.json
under hindi translation with missing key-valuesfilter
placeholder in NamespacesAutocomplete.tsxScreenshots