Skip to content

frontend: i18n: Add missing translations for UI #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

SinghaAnirban005
Copy link
Contributor

@SinghaAnirban005 SinghaAnirban005 commented May 29, 2025

Summary

This PR adds the missing Hindi translations for several UI components that were previously displaying English text despite the Hindi language being selected. Ensuring complete localization improves accessibility and user experience for Hindi-speaking users.

Fixes #3386

Changes Made

  1. Updated glossary.json under hindi translations
  2. Updated translation.json under hindi translation with missing key-values
  3. Translated the filter placeholder in NamespacesAutocomplete.tsx

Screenshots

  1. Global Search component

Screenshot from 2025-05-29 14-25-59

Screenshot from 2025-05-29 14-26-05

  1. Filter placeholder

Screenshot from 2025-05-29 14-26-40

  1. Expand/Shrink Sidebar labels

Screenshot from 2025-05-29 14-27-08

Screenshot from 2025-05-29 14-27-19

  1. "General" tab in settings

Screenshot from 2025-05-29 14-27-48

Copy link

linux-foundation-easycla bot commented May 29, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 29, 2025
@k8s-ci-robot k8s-ci-robot requested review from ashu8912 and illume May 29, 2025 09:59
@k8s-ci-robot
Copy link
Contributor

Welcome @SinghaAnirban005!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 29, 2025
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 😃

I think the changes to the Filter translations are unrelated to the missing Hindi translations, maybe they could be better separated by the commits. I would suggest the following:

  • Separate the commits into (1) filling in missing Hindi translations and (2) the change to NamespacesAutocomplete with all the subsequent filter translations
  • Adjust the PR title to reflect the broader scope of the changes (e.g. frontend: i18n: Add missing translations for UI)

@SinghaAnirban005
Copy link
Contributor Author

@skoeva Will update it soon 🚀

@SinghaAnirban005 SinghaAnirban005 force-pushed the bug/translations branch 2 times, most recently from de4ac3c to 52cca9d Compare May 30, 2025 20:01
@SinghaAnirban005 SinghaAnirban005 changed the title Frontend: add missing Hindi translations for UI components frontend: i18n: Add missing translations for UI May 30, 2025
@SinghaAnirban005 SinghaAnirban005 requested a review from skoeva May 30, 2025 20:02
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can clarify what I mean by the separation. We can have two commits here:

  • One commit for the missing Hindi translations (not including any of the changes to the "Filter" translations): frontend: i18n: Add missing Hindi translations
  • One commit for the "Filter" translations (the NamespacesAutocomplete change as well as the updated translation files): something like frontend: NamespacesAutocomplete: Translate placeholder text

Be sure to rebase as well to keep the branch up to date

@SinghaAnirban005 SinghaAnirban005 force-pushed the bug/translations branch 3 times, most recently from 237232f to 79be572 Compare June 5, 2025 20:03
@SinghaAnirban005 SinghaAnirban005 requested a review from skoeva June 5, 2025 20:05
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 23, 2025
@illume illume force-pushed the bug/translations branch from 7d06150 to 56362b9 Compare June 24, 2025 12:30
@illume
Copy link
Contributor

illume commented Jun 24, 2025

Fixed a conflict rebased against main.

Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, SinghaAnirban005, skoeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@illume illume merged commit 577af03 into kubernetes-sigs:main Jun 24, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

Missing Hindi Translations in Several UI Components
4 participants