Skip to content

Split Makefile targets for native and multiarch builds #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Split Makefile targets for native and multiarch builds #5414

wants to merge 1 commit into from

Conversation

carterpewpew
Copy link

/kind feature

What this PR does / why we need it:

This PR introduces support for building multi-architecture images (e.g., s390x, ppc64le) for the Kueue project.

  • Adds a make image-build target to support multiarch builds using Docker Buildx
  • Adds a kind-image-build target for building native platform images
  • Splits native and multiarch logic in the Makefile
  • Keeps all existing build and test functionality unchanged

Which issue(s) this PR fixes:

Fixes #5166

Special notes for your reviewer:

Makefile changes only.

Does this PR introduce a user-facing change?

NONE

@carterpewpew
Split Makefile targets for native and multiarch builds
287165e 
- Added image-build for multiarch (s390x, ppc64le)
- Added kind-image-build for native builds using host platform
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 30, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 30, 2025
@k8s-ci-robot k8s-ci-robot requested a review from gabesaba May 30, 2025 05:00
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carterpewpew
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from mimowo May 30, 2025 05:00
@k8s-ci-robot
Copy link
Contributor

Welcome @carterpewpew!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @carterpewpew. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 30, 2025
@netlify Netlify
Copy link

netlify bot commented May 30, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 287165e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68393b60a110f20008efb126
😎 Deploy Preview https://deploy-preview-5414--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@carterpewpew carterpewpew marked this pull request as draft May 30, 2025 06:06
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2025
@mbobrovskyi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2025
mbobrovskyi
mbobrovskyi reviewed May 30, 2025
View reviewed changes
Makefile
Comment on lines +256 to +267
.PHONY: image-build-multiarch
image-build-multiarch:
$(IMAGE_BUILD_CMD) -t $(IMAGE_TAG) \
--platform=$(MULTIARCH_PLATFORMS) \
--build-arg BASE_IMAGE=$(BASE_IMAGE) \
--build-arg BUILDER_IMAGE=$(BUILDER_IMAGE) \
--build-arg CGO_ENABLED=$(CGO_ENABLED) \
--build-arg GIT_TAG=$(GIT_TAG) \
--build-arg GIT_COMMIT=$(GIT_COMMIT) \
$(PUSH) \
$(IMAGE_BUILD_EXTRA_OPTS) ./

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I can see is the PLATFORMS variable. Is this command enough?

make image-build PLATFORMS=linux/s390x,linux/ppc64le

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree with you. I don't think we should have a separate make target.
We can just specify the PLATFORMS in CI configurations.

@mbobrovskyi
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@gabesaba gabesaba Awaiting requested review from gabesaba

@mimowo mimowo Awaiting requested review from mimowo

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

revisit building power/s390x?
4 participants
@carterpewpew @k8s-ci-robot @mbobrovskyi @tenzen-y