Skip to content

Update KEP-77 with additional details and focus on batchv1/Job #5648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 22, 2025

Conversation

ichekrygin
Copy link
Contributor

@ichekrygin ichekrygin commented Jun 14, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates the already accepted KEP-77 by fleshing out additional design details and aligning it with recent changes and constructs in Kueue. These updates provide a clearer path for both contributors and reviewers and reflect the current direction of the implementation.

Which issue(s) this PR fixes:

Fixes #5527

Special notes for your reviewer:

This PR enhances KEP-77 by expanding on the design to support batch/v1.Job horizontal scaling and aligning terminology and workflows with current Kueue capabilities.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ichekrygin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 14, 2025
Copy link

netlify bot commented Jun 14, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit af1e7e6
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/687e62465cc27d0007d276c4

@ichekrygin ichekrygin requested a review from andrewsykim June 27, 2025 05:41
@mimowo
Copy link
Contributor

mimowo commented Jun 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Jun 27, 2025

I'm planning to review this early next week.

Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, but it LGTM as for Alpha IMO.

cc @tenzen-y

@ichekrygin
Copy link
Contributor Author

Thank you, @mimowo, for the detailed review and insights. I’ve addressed and/or responded to all the comments in your review. Could you please take another look when you have a moment?

Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
@mimowo
Copy link
Contributor

mimowo commented Jul 8, 2025

We only add release notes to PRs which directly have user-facing consequences.
/release-note-edit

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 8, 2025
@mimowo
Copy link
Contributor

mimowo commented Jul 8, 2025

I'm thinking about renaming the feature (and associated things like feature gate or KEP title) from DynamicallySizedJobs to ElasticJobs. It is shorter to pronounce and captures the very same idea.

Wdyt @tenzen-y @ichekrygin ?

@ichekrygin
Copy link
Contributor Author

I'm thinking about renaming the feature (and associated things like feature gate or KEP title) from DynamicallySizedJobs to ElasticJobs. It is shorter to pronounce and captures the very same idea.

Wdyt @tenzen-y @ichekrygin ?

ElasticJobs SGTM, as long as we use WorkloadSlices as the implementation detail.

Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
ichekrygin and others added 10 commits July 21, 2025 08:43
Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
…eadiness gate.

Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
@ichekrygin
Copy link
Contributor Author

Hello @mimowo @tenzen-y thank you for the review and feedback.
I have reviewed all comments and updated KEP per provided feed back.

Note: WorkloadSliceReplacement -> WorkloadSliceReplaced change was discussed in the context of #5510.

@mimowo
Copy link
Contributor

mimowo commented Jul 21, 2025

Thank you! It is a complex, but long awaited KEP :) The number 77 says everything, I'm super happy you took the challenge.

/lgtm
/approve
Leaving final tagging to @tenzen-y
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: da4dd0a6729042ce86b2bbe045daced832609f4b

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2025
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this awesome work!
/lgtm
/approve

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ichekrygin, mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dc3a13c into kubernetes-sigs:main Jul 22, 2025
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.13 milestone Jul 22, 2025
@ichekrygin ichekrygin deleted the kep-77-update branch July 23, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update KEP-77 with details on batch/v1.Job support for horizontal scaling
6 participants