-
Notifications
You must be signed in to change notification settings - Fork 382
Update KEP-77 with additional details and focus on batchv1/Job #5648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @ichekrygin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
b29f179
to
5ecdddb
Compare
/ok-to-test |
I'm planning to review this early next week. |
5ecdddb
to
13df9c8
Compare
Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, but it LGTM as for Alpha IMO.
cc @tenzen-y
Thank you, @mimowo, for the detailed review and insights. I’ve addressed and/or responded to all the comments in your review. Could you please take another look when you have a moment? |
Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
We only add release notes to PRs which directly have user-facing consequences.
|
I'm thinking about renaming the feature (and associated things like feature gate or KEP title) from DynamicallySizedJobs to ElasticJobs. It is shorter to pronounce and captures the very same idea. Wdyt @tenzen-y @ichekrygin ? |
|
Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
f850d00
to
e31cbdb
Compare
Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
…eadiness gate. Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
Thank you! It is a complex, but long awaited KEP :) The number 77 says everything, I'm super happy you took the challenge. /lgtm |
LGTM label has been added. Git tree hash: da4dd0a6729042ce86b2bbe045daced832609f4b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this awesome work!
/lgtm
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ichekrygin, mimowo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR updates the already accepted KEP-77 by fleshing out additional design details and aligning it with recent changes and constructs in Kueue. These updates provide a clearer path for both contributors and reviewers and reflect the current direction of the implementation.
Which issue(s) this PR fixes:
Fixes #5527
Special notes for your reviewer:
This PR enhances KEP-77 by expanding on the design to support batch/v1.Job horizontal scaling and aligning terminology and workflows with current Kueue capabilities.
Does this PR introduce a user-facing change?