Bump github.com/ray-project/kuberay/ray-operator from 1.3.2 to 1.4.0 #5722
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
ok-to-test
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XL
|
/retest |
| @@ -1,6 +1,6 @@ | |||
| module sigs.k8s.io/kueue | |||
|
|
|||
| go 1.24.0 | |||
| go 1.24.2 | |||
There was a problem hiding this comment.
/hold
I think this is an unexpected change.
There was a problem hiding this comment.
Yeah, it was bumped in kuberay:
https://github.com/ray-project/kuberay/blob/release-1.4/ray-operator/go.mod#L3.
There was a problem hiding this comment.
IIUC, even when the downstream go patch version is upgraded, we do not need to reflect it to the Kueue side.
Could you check it?
There was a problem hiding this comment.
No, it gets updated automatically when running go mod tidy.
There was a problem hiding this comment.
I think it's fine to bump it for v0.13.0.
There was a problem hiding this comment.
sgtm, I would not look for workaround if this is automated, especially as this PR is only for 0.13.0
There was a problem hiding this comment.
IIUC, recently this patch version restriction was relaxed. Let's see if this is really needed.
In this upstream, this is not issue. However enforcing upper Go version is problem for downstream users who implement external AC and Job Integrations.
What about using 1.24 instead of 1.24.0?
There was a problem hiding this comment.
As I checked locally with 1.24 and 1.24.0, both are no available...
There was a problem hiding this comment.
It might be better to bump the Go version in a separate PR, so we can update all related places consistently.
k8s-ci-robot
added
the
do-not-merge/hold
Bumps [github.com/ray-project/kuberay/ray-operator](https://github.com/ray-project/kuberay) from 1.3.2 to 1.4.0. - [Release notes](https://github.com/ray-project/kuberay/releases) - [Commits](ray-project/kuberay@v1.3.2...v1.4.0) --- updated-dependencies: - dependency-name: github.com/ray-project/kuberay/ray-operator dependency-version: 1.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/ray-project/kuberay/ray-operator-1.4.0
branch
from
e03c8ce to
dd1ca8b
Compare
Bumps github.com/ray-project/kuberay/ray-operator from 1.3.2 to 1.4.0.
Release notes
Sourced from github.com/ray-project/kuberay/ray-operator's releases.
... (truncated)
Commits
279b9f0[Release] Update KubeRay version references for 1.4.0 (#3816)270c79b[kubeclt-plugin] fix get cluster all namespace (#3809) (#3814)ee1a435[Docs] Add kubectl plugin create cluster sample yaml config files (#3804) (#3...4986795[Helm Chart] Set honorLabel of serviceMonitor to true (#3805) (#3810)b5cdd00[Metrics] Remove serviceMonitor.yaml (#3795) (#3798)e6bd610[Chore][Sample-yaml] Upgrade pytorch-lightning to 1.8.5 for ray-job.pytorch-d...6a74bdaUse ImplementationSpecific in ray-cluster.separate-ingress.yaml (#3781) (#3790)6d83d70Remove vLLM examples in favor of Ray Serve LLM (#3786) (#3789)bd8930eUpdate update-ray-job.kueue-toy-sample.yaml (#3782) (#3788)cfd0bfa[Feat] Add e2e test for applyingray-job.interactive-mode.yaml(#3779) (#3787)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)