-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Closed
Labels
area/cluster-autoscalerkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Description
Which component are you using?:
/area cluster-autoscaler
Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
Cluster Autoscaler has a --cordon-node-before-terminating
flag, but it is set to false by default. I think we should always cordon nodes before deleting them.
Describe the solution you'd like.:
- (short term) Flip the default flag value to
true
. Mark the flag as deprecated & planned for removal. - (in 1-2 minor releases) Delete the flag.
Describe any alternative solutions you've considered.:
Keep as is. Or keep the flag. I didn't find any good reason to do any of these things.
Additional context.:
Lack of cordoning has been a pain point since forever (#1136, #2505, #2868, #3648). It was later added as an option hidden behind a flag, but it could just work out of the box instead of requiring manual setup.
Metadata
Metadata
Assignees
Labels
area/cluster-autoscalerkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
x13n commentedon Jun 2, 2025
/hold
Putting on hold so it lands in 1.34 release, not 1.33, as discussed on the SIG meeting.
x13n commentedon Jun 2, 2025
Whoops, meant to add this on the PR, not the issue.