Skip to content

fix bug 8168 GetEndpoint resolving fail #8169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

maximrub
Copy link
Contributor

@maximrub maximrub commented May 26, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #8168

Special notes for your reviewer:

There is an endpoint resolution failure due to a changed JSON schema, causing scaling groups not to be discovered. Because of this, the autoscaler doesn't work at all.
failed to unmarshal endpoint response, error: json: cannot unmarshal array into Go struct field EndpointObj.Endpoints.Endpoint.Protocols of type string
The Protocols is not at use at all.

Does this PR introduce a user-facing change?

no

alicloud: fix Endpoint Resolution

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 26, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @maximrub. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/cluster-autoscaler area/provider/alicloud Issues or PRs related to the AliCloud cloud provider implementation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2025
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@maximrub
Copy link
Contributor Author

@aleksandra-malinowska @vadasambar can you please have a look?

@maximrub
Copy link
Contributor Author

maximrub commented Jun 5, 2025

@maximrub
Copy link
Contributor Author

maximrub commented Jun 6, 2025

@x13n @ringtail can you please look on this one too?

@x13n
Copy link
Member

x13n commented Jun 9, 2025

I don't have the required context for this cloud provider, but the change looks ok from core CA perspective, so can approve after @ringtail LGTM.

@maximrub
Copy link
Contributor Author

@ringtail can you please have a look?

@maximrub
Copy link
Contributor Author

@x13n @ringtail is there someone else who can look into this?

@ringtail
Copy link
Contributor

@x13n @ringtail is there someone else who can look into this?

/LGTM

@k8s-ci-robot
Copy link
Contributor

@ringtail: changing LGTM is restricted to collaborators

In response to this:

@x13n @ringtail is there someone else who can look into this?

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@x13n
Copy link
Member

x13n commented Jun 24, 2025

Approving per the comments above.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximrub, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit c509bb2 into kubernetes:master Jun 24, 2025
6 of 7 checks passed
@maximrub
Copy link
Contributor Author

@x13n @ringtail I will do a cherry pick to 1.32.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/alicloud Issues or PRs related to the AliCloud cloud provider implementation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster Autoscaler Endpoint Resolution doesn't work in Alibaba Cloud
5 participants