-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix bug 8168 GetEndpoint resolving fail #8169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug 8168 GetEndpoint resolving fail #8169
Conversation
Hi @maximrub. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
@aleksandra-malinowska @vadasambar can you please have a look? |
I don't have the required context for this cloud provider, but the change looks ok from core CA perspective, so can approve after @ringtail LGTM. |
@ringtail can you please have a look? |
@ringtail: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Approving per the comments above. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximrub, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #8168
Special notes for your reviewer:
There is an endpoint resolution failure due to a changed JSON schema, causing scaling groups not to be discovered. Because of this, the autoscaler doesn't work at all.
failed to unmarshal endpoint response, error: json: cannot unmarshal array into Go struct field EndpointObj.Endpoints.Endpoint.Protocols of type string
The Protocols is not at use at all.
Does this PR introduce a user-facing change?
no