Skip to content

KEP 4680: Update README.md for DRA #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

Conversation

Jpsassine
Copy link
Contributor

@Jpsassine Jpsassine commented May 13, 2025

This update transfers the design details from https://docs.google.com/document/d/1CopUHEeTebGeSb3jvmHkpABACAnrDFj5OCmEqRSKCDY/edit?usp=sharing

  • One-line PR description: Updating the KEP to include the detailed design for updating pod status with device health for DRA.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 13, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @Jpsassine!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 13, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Jpsassine. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2025
@Jpsassine
Copy link
Contributor Author

@SergeyKanzhelev
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2025
@SergeyKanzhelev SergeyKanzhelev changed the title Update README.md KEP 4680: Update README.md for DRA May 19, 2025
@SergeyKanzhelev
Copy link
Member

cc: @pohly @bart0sh @johnbelamaric

@bart0sh
Copy link
Contributor

bart0sh commented May 22, 2025

/cc @klueska

@k8s-ci-robot k8s-ci-robot requested a review from klueska May 22, 2025 14:47
@mortent
Copy link
Member

mortent commented Jun 9, 2025

/wg device-management

@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Jun 9, 2025
@SergeyKanzhelev
Copy link
Member

/assign @pohly

@pohly any concerns with this design?

@pohly pohly moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Jun 10, 2025
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major concerns from me about the design. It's quite a bit of additional code and complexity and feels a bit redundant, but I understand that surfacing the health information in the pod status needs it.

Some nit and suggestions.

string pool_name = 1;
// The unique name of the device within the pool.
// Required.
string device_name = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref: #5104 (comment)

TLDR: "device name" will become <device name>[/<share ID>] once consumable capacities allow allocating the same device multiple times. This is consistent with the proposed API here, it just needs an updated description - but not now! It depends on the order in which the implementations get merged.

cc @sunya-ch

Previously the design dug too much into the code details which is not the focus. Now it focuses on the higher level design and not the direct code implementation.
Ran ./hack/update-toc.sh
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jpsassine, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2025
@mrunalp
Copy link
Contributor

mrunalp commented Jun 16, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4b35dea into kubernetes:master Jun 16, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 16, 2025
@pohly pohly moved this from 👀 In review to ✅ Done in Dynamic Resource Allocation Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants