-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP 4680: Update README.md for DRA #5302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This update transfers the design details from https://docs.google.com/document/d/1CopUHEeTebGeSb3jvmHkpABACAnrDFj5OCmEqRSKCDY/edit?usp=sharing
Welcome @Jpsassine! |
Hi @Jpsassine. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/cc @klueska |
/wg device-management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major concerns from me about the design. It's quite a bit of additional code and complexity and feels a bit redundant, but I understand that surfacing the health information in the pod status needs it.
Some nit and suggestions.
string pool_name = 1; | ||
// The unique name of the device within the pool. | ||
// Required. | ||
string device_name = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xref: #5104 (comment)
TLDR: "device name" will become <device name>[/<share ID>]
once consumable capacities allow allocating the same device multiple times. This is consistent with the proposed API here, it just needs an updated description - but not now! It depends on the order in which the implementations get merged.
cc @sunya-ch
Previously the design dug too much into the code details which is not the focus. Now it focuses on the higher level design and not the direct code implementation.
Ran ./hack/update-toc.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jpsassine, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This update transfers the design details from https://docs.google.com/document/d/1CopUHEeTebGeSb3jvmHkpABACAnrDFj5OCmEqRSKCDY/edit?usp=sharing
Issue link: Add Resource Health Status to the Pod Status for Device Plugin and DRA #4680
Reference doc https://docs.google.com/document/d/1CopUHEeTebGeSb3jvmHkpABACAnrDFj5OCmEqRSKCDY/edit?usp=sharing