-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[KEP-4639] Image Volume: remove noexec option #5354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bitoku
commented
May 30, 2025
- One-line PR description: updating ImageVolume KEP
- Issue link: https://kep.k8s.io/4639
- Other comments: discussion link in slack https://kubernetes.slack.com/archives/C0BP8PW9G/p1747855940240409
Welcome @bitoku! |
Hi @bitoku. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, makes sense to drop the noexec
in these statements. Should we say explicitly that the Container Runtime needs to allow exec explicitly? Or we just rely on whatever behavior the runtime will do?
Perhaps create a critest to ensure that exec is allowed?
@SergeyKanzhelev IMHO we don't need to ensure it because we don't say explicitly for other options. |
/lgtm I think it will be useful to document that it will be mounted with exec in the API and ideally add the critest for it. But I agree that it is a default assumption here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, mikebrow, mrunalp, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |