-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-5067: promote Pod Generation to beta #5377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sig node review: prr review: |
de988af
to
03b10bc
Compare
03b10bc
to
7c6a23a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
6eedb04
to
c442b64
Compare
c442b64
to
102372b
Compare
/assign @soltysh based on #5377 (comment) |
my lgtm stands, but now PRR approver can apply it |
9484c01
to
b591417
Compare
PRR shadow: LGTM to me. /assign @soltysh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several comments to address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we have the metrics copied over to kep.yaml, this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
the PRR
/label tide/merge-method-squash |
re-adding lgtm based on previous Sergey's comment |
/assign @dchen1107 |
Approve based on @SergeyKanzhelev @tallclair @kannon92's review. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, natasha41575, SergeyKanzhelev, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Promoting Pod Generation to beta. All the requirements were implemented in 1.33, so this update is just filling out the PRR questionnaire for beta.
Issue link: #5067