-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Documentation for Swap memory management #51303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
/cc @ajaysundark |
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this - it's really needed.
Here's quite a lot of feedback.
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial feedback
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
6a0b0d5
to
bde09da
Compare
I looked into it quick, I'll spend more time to continue review on this. IMHO, the changes could add more structure for better flow. Admins are often in a hurry. The final document should be easy to scan for. |
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/configuration/provision-swap-memory.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
2a8bdec
to
ef22d32
Compare
@ajaysundark thanks for the review! Appreciate it. I believe your comments are addressed now. Can you please take another look? |
Hey @lmktfy @ajaysundark! |
I think you probably can still edit the PR to change the destination branch as dev-1.34. Would need to rebase your original branch as well. |
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from node side.
maybe @haircommander would like to take a look also?
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/cluster-administration/swap-memory-management.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
Thanks a lot @haircommander and @kannon92 for your reviews! Much appreciated! |
|
||
<!-- overview --> | ||
|
||
This page provides an example of how to provision and configure swap memory on a Kubernetes node using kubeadm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be something that makes it clear this is linux only early on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah you mention it below that's prbaobly fine
this is an excellent improvement |
LGTM label has been added. Git tree hash: 6242b4d55807a1ca14edc11f1bf45f7b54d699c6
|
@natalisucks can you please take another look? |
/approve Thanks, @iholder101. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks everyone for your reviews and work! nice addition, @iholder101 🎉 |
Description
Add documentation for KEP-2400 NodeSwap GA.
Basically, this PR does 2 things:
content/en/docs/concepts/cluster-administration/swap-memory-management.md
. This documentation is heavily based on the contents of the latest blog-post about swap memory: https://kubernetes.io/blog/2025/03/25/swap-linux-improvements/. While the content is very similar, there are minor updates.content/en/docs/concepts/architecture/nodes.md
.This documentation should contain everything the user needs to know for swap GA.
Issue
Fixes #51153