Allow dataset upload tags from list selector #1364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzegorz-roboflow
approved these changes
Jun 17, 2025
NickHerrig
requested review from
PawelPeczek-Roboflow,
yeldarby,
probicheaux and
hansent
as code owners
grzegorz-roboflow
approved these changes
Jun 26, 2025
grzegorz-roboflow
deleted the
codex/fix-invalid-list-input-for-registration_tags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
registration_tagsTesting
make stylemake check_code_quality(fails: flake8 not found)pytest tests/workflows/unit_tests/core_steps/sinks/roboflow/roboflow_dataset_upload/test_v2.py::test_manifest_parsing_when_registration_tags_given_as_selector -q(fails: ModuleNotFoundError: No module named 'cv2')https://chatgpt.com/codex/tasks/task_e_685096b20da8832dabc26f9ae1da004e