Allow null as transactions errors value #460
Open
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveBeckerMSFT
requested changes
Jun 13, 2025
| @@ -5144,8 +5148,7 @@ To <dfn>abort a transaction</dfn> with the |transaction| to abort, and |error|, | |||
|
|
|||
| 1. Set |transaction|'s [=transaction/state=] to [=transaction/finished=]. | |||
|
|
|||
| 1. If |error| is not null, set |transaction|'s | |||
| [=transaction/error=] to |error|. | |||
| 1. Set |transaction|'s [=transaction/error=] to |error|. | |||
There was a problem hiding this comment.
Do we need to include the condition that @inexorabletash suggested in his proposed minimal fix?
"If |error| us not set, set |transaction|'s [=transaction/error=] to |error|."
I think this might be needed if we call "abort a transaction" on a transaction that is already aborted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some work towards fixing the issues mentioned in #433
I feel like introducing a separate flag/field for this would be clearer.
Or maybe passing an
AbortError DOMExceptionin IDBTransaction::abort() (But maybe this breaks something 🤷 )The following tasks have been completed:
Implementation commitment:
Preview | Diff