Suggestions from January review on §1.4 #194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchampin
added
the
spec:enhancement
hartig
requested changes
Apr 24, 2025
hartig
approved these changes
Apr 24, 2025
TallTed
suggested changes
Apr 24, 2025
TallTed
reviewed
Apr 25, 2025
gkellogg
approved these changes
Apr 26, 2025
afs
reviewed
Apr 28, 2025
|
Isn't this just editorial. |
Bob DuCharme's 2nd comment https://www.w3.org/mid/33e6564c-0dc3-4ca6-8304-4e47da867bf6@snee.com not exactly Bob's suggestion, but I think it addresses the core of the issue.
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
re-reading this, I realized it could be surprising: the predicate position of a triple is a "context where IRIs are expected", and so this text could read as "don't use abbreviated forms in the predicate position", which is of course not how it was intended.
pchampin
force-pushed
the
2025-01-reviews-s1.4
branch
from
5f5790b to
9ee0284
Compare
... with some slight adaptations *: #194 (comment)
TallTed
reviewed
Jul 7, 2025
| RDF data model. They are merely a syntactic convenience for | ||
| abbreviating IRIs.</p> | ||
| Note however that such abbreviations are <em>not</em> meant to be processed directly as IRIs, | ||
| and must not be used in syntactic contexts where IRIs are expected. |
There was a problem hiding this comment.
I've lost track of normativity. Should this use MUST instead of must?
Suggested change
| and must not be used in syntactic contexts where IRIs are expected. | |
| and must not be used in syntactic contexts where IRIs are expected. |
There was a problem hiding this comment.
No. This is in §1.4; §1 (Introduction) as a whole is informative.
There was a problem hiding this comment.
Does this work?
Suggested change
| and must not be used in syntactic contexts where IRIs are expected. | |
| and are not to be used in syntactic contexts where IRIs are expected. |
TallTed
reviewed
Jul 7, 2025
TallTed
reviewed
Jul 7, 2025
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
afs
approved these changes
Jul 8, 2025
Co-authored-by: Andy Seaborne <andy@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff