Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cors): treat empty Origin header same as missing header #14368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dingjiayi
Copy link
Contributor

@dingjiayi dingjiayi commented Mar 18, 2025

Summary

This change ensures that an empty Origin header (Origin: "") is treated
the same way as a missing Origin header, fixing inconsistent behavior
between these two cases.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #14352

@dingjiayi dingjiayi closed this Mar 18, 2025
@dingjiayi dingjiayi reopened this Mar 18, 2025
@dingjiayi dingjiayi marked this pull request as draft March 18, 2025 08:34
@dingjiayi dingjiayi marked this pull request as ready for review March 18, 2025 12:16
@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin(cors):Assertion failure on empty origin header
2 participants