Hamlib rotator support #455
Conversation
|
It works for me, but there's a few open ends:
Comments, feedback? |
| @@ -353,6 +355,18 @@ int rignumber = 0; | |||
| int rig_comm_error = 0; | |||
| int rig_comm_success = 0; | |||
|
|
|||
| /*-------------------------------------rotctl-------------------------------*/ | |||
| bool rot_control = false; | |||
There was a problem hiding this comment.
set the default values in init_variables() in order to allow clean re-initialization.
I know that not all globals are covered, but for new ones this shall be done.
|
|
||
| if (pfx_index != my.countrynr && 0 == get_qrb(&range, &bearing)) { | ||
|
|
||
| pthread_mutex_lock(&tlf_rot_mutex); |
There was a problem hiding this comment.
do we need a mutex for rot?
rig controls are called from both threads (main + background), but rot looks to be called from main only.
another question: does rot_set_position() just send a message to the rotator and doesn't wait for it to actually reach to requested position?
There was a problem hiding this comment.
We probably don't need the mutex now, but I would think it's safer to include it. New code might violate the assumption.
set_position just starts the rotation. You wouldn't want the rest of the program to halt for a minute while the antenna is turning...
Thanks for the review, will fix the variable init later.
There was a problem hiding this comment.
Do hamlib guarantee that you can call functions for rig control and rotator control at the same time?
Otherwise (as set_position comes back immediately) why not use tlf_rig_mutex for both?
There was a problem hiding this comment.
rig control and rotator control are talking to different devices, so calling functions at the same time is not a problem.
We could use the same mutex, but... this feels wrong.
| endwin(); | ||
| exit(1); | ||
| } | ||
| trx_control = false; |
| exit(1); | ||
| } | ||
| trx_control = false; | ||
| trx_control_disabled = true; |
|
|
||
| if (pfx_index != my.countrynr && 0 == get_qrb(&range, &bearing)) { | ||
|
|
||
| pthread_mutex_lock(&tlf_rot_mutex); |
There was a problem hiding this comment.
Do hamlib guarantee that you can call functions for rig control and rotator control at the same time?
Otherwise (as set_position comes back immediately) why not use tlf_rig_mutex for both?
There was a problem hiding this comment.
Needs mention of Ctrl-D in the KEYS section.
This adds Hamlib rotator support to tlf. When a call or prefix is entered, pressing Ctrl-D rotates the antenna to the calculated bearing.