Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interop client] provide a flag to set google-c2p resolver universe domain #8145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Mar 5, 2025

Documentation PR: grpc/grpc#38933

RELEASE NOTES: N/A

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (8c080da) to head (f9c06c8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8145      +/-   ##
==========================================
+ Coverage   82.39%   82.43%   +0.04%     
==========================================
  Files         389      389              
  Lines       39125    39125              
==========================================
+ Hits        32238    32254      +16     
+ Misses       5568     5556      -12     
+ Partials     1319     1315       -4     

see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apolcyn apolcyn marked this pull request as ready for review March 5, 2025 22:30
@arjan-bal arjan-bal added this to the 1.72 Release milestone Mar 6, 2025
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should wait for grpc/grpc#38933 to be merged before merging this to ensure the flag name and behaviour are finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants