[interop client] provide a flag to set google-c2p resolver universe domain #8145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8145 +/- ##
==========================================
+ Coverage 82.39% 82.43% +0.04%
==========================================
Files 389 389
Lines 39125 39125
==========================================
+ Hits 32238 32254 +16
+ Misses 5568 5556 -12
+ Partials 1319 1315 -4 🚀 New features to boost your workflow:
|
arjan-bal
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
LGTM, I think we should wait for grpc/grpc#38933 to be merged before merging this to ensure the flag name and behaviour are finalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation PR: grpc/grpc#38933
RELEASE NOTES: N/A