Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add List method to gRPC Health service #8155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marcoshuck
Copy link

This change introduces a new List RPC endpoint for the Health service, allowing clients to retrieve the statuses of all monitored services. This feature simplifies integration with status-reporting dashboards and enhances observability for microservices.

Proposal: grpc/proposal#468
gRPC-proto change: grpc/grpc-proto#143

This change introduces a new `List` RPC endpoint for the Health service, allowing clients to retrieve the statuses of all monitored services. This feature simplifies integration with status-reporting dashboards and enhances observability for microservices.

Proposal: grpc/proposal#468
gRPC-proto change: grpc/grpc-proto#143
Signed-off-by: Marcos Huck <marcos@huck.com.ar>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I regenerated the Go stubs using the work in progress version of grpc/grpc-proto#143

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I regenerated the Go stubs using the work in progress version of grpc/grpc-proto#143

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (5668c66) to head (23a4f3a).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8155      +/-   ##
==========================================
- Coverage   82.32%   82.17%   -0.16%     
==========================================
  Files         392      393       +1     
  Lines       39140    39159      +19     
==========================================
- Hits        32222    32177      -45     
- Misses       5597     5648      +51     
- Partials     1321     1334      +13     
Files with missing lines Coverage Δ
health/server.go 95.83% <100.00%> (+0.83%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoshuck i think we need to wait for the proposal and proto change to be merged before this? I still see them in review

@dfawley cc

@purnesh42H purnesh42H added Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability Type: Feature New features or improvements in behavior Status: Requires Reporter Clarification labels Mar 10, 2025
Signed-off-by: Marcos Huck <marcos@huck.com.ar>
Copy link

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

@github-actions github-actions bot added the stale label Mar 19, 2025
@marcoshuck marcoshuck requested a review from purnesh42H March 19, 2025 23:07
@github-actions github-actions bot removed the stale label Mar 20, 2025
@dfawley dfawley assigned purnesh42H and unassigned marcoshuck Mar 20, 2025
@dfawley dfawley added Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability and removed Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants