Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: fix support for load reporting in LOGICAL_DNS clusters #8170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Mar 13, 2025

(To avoid merge conflicts, this also contains #8169 as the first commit.)

While fixing #8169, we noticed that LRS was also not being plumbed to LOGICAL_DNS clusters. This change adds support for it and an e2e test to ensure the LRS server is being used as intended.

RELEASE NOTES:

  • xds: fix support for load reporting in LOGICAL_DNS clusters

@dfawley dfawley added this to the 1.72 Release milestone Mar 13, 2025
@dfawley dfawley requested a review from purnesh42H March 13, 2025 21:15
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (775150f) to head (0706a7f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8170      +/-   ##
==========================================
+ Coverage   82.25%   82.27%   +0.02%     
==========================================
  Files         393      393              
  Lines       39143    39147       +4     
==========================================
+ Hits        32197    32209      +12     
+ Misses       5616     5607       -9     
- Partials     1330     1331       +1     
Files with missing lines Coverage Δ
xds/internal/balancer/cdsbalancer/cdsbalancer.go 84.63% <100.00%> (+0.07%) ⬆️
...internal/balancer/clusterresolver/configbuilder.go 91.17% <100.00%> (+0.10%) ⬆️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRS change LGTM. Have added comments in other PR

return host, uint32(port)
}

func (s) TestLRSLogicalDNS(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docstring for the test

@purnesh42H purnesh42H assigned dfawley and unassigned purnesh42H Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants