xds: fix support for load reporting in LOGICAL_DNS clusters #8170
+313
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8170 +/- ##
==========================================
+ Coverage 82.25% 82.27% +0.02%
==========================================
Files 393 393
Lines 39143 39147 +4
==========================================
+ Hits 32197 32209 +12
+ Misses 5616 5607 -9
- Partials 1330 1331 +1
🚀 New features to boost your workflow:
|
purnesh42H
approved these changes
Mar 18, 2025
| return host, uint32(port) | ||
| } | ||
|
|
||
| func (s) TestLRSLogicalDNS(t *testing.T) { |
There was a problem hiding this comment.
Please add docstring for the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(To avoid merge conflicts, this also contains #8169 as the first commit.)
While fixing #8169, we noticed that LRS was also not being plumbed to LOGICAL_DNS clusters. This change adds support for it and an e2e test to ensure the LRS server is being used as intended.
RELEASE NOTES: