-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: fix support for load reporting in LOGICAL_DNS clusters #8170
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8170 +/- ##
==========================================
- Coverage 82.16% 81.96% -0.21%
==========================================
Files 410 410
Lines 40235 40237 +2
==========================================
- Hits 33060 32979 -81
- Misses 5824 5889 +65
- Partials 1351 1369 +18
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LRS change LGTM. Have added comments in other PR
return host, uint32(port) | ||
} | ||
|
||
func (s) TestLRSLogicalDNS(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add docstring for the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
0706a7f
to
fea6ee2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and added comment. Thanks!
return host, uint32(port) | ||
} | ||
|
||
func (s) TestLRSLogicalDNS(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
(To avoid merge conflicts, this also contains #8169 as the first commit.)
While fixing #8169, we noticed that LRS was also not being plumbed to LOGICAL_DNS clusters. This change adds support for it and an e2e test to ensure the LRS server is being used as intended.
RELEASE NOTES: