Display mod tooltips in rich form #32540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Mar 25, 2025
Comment on lines
+68
to
+83
| new TextFlowContainer(t => | ||
| { | ||
| t.Font = OsuFont.Torus.With(size: 12f, weight: FontWeight.SemiBold); | ||
| }) | ||
| { | ||
| AutoSizeAxes = Axes.Both, | ||
| Colour = colourProvider.Content2, | ||
| Text = string.Join('\n', mod.SettingDescription.Select(svp => svp.setting)), | ||
| }, | ||
| new TextFlowContainer(t => | ||
| { | ||
| t.Font = OsuFont.Torus.With(size: 12f, weight: FontWeight.SemiBold); | ||
| }) | ||
| { | ||
| Anchor = Anchor.TopRight, | ||
| Origin = Anchor.TopRight, |
There was a problem hiding this comment.
I have grave concerns about this breaking in the future and requiring proper grid layout. But I'm going to go with this and we'll see if you have to rewrite this in a day or two.
peppy
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced from the new song select design, specific page containing the design was since lost with the continuous movement of the iterations, but I think it's quite nice to have.
Mod preset tooltip design has also been updated in line with the new rich form design.
Preview:
CleanShot.2025-03-23.at.13.38.43.mp4
CleanShot.2025-03-23.at.13.39.02.mp4