newBuildSystem #852
Open
newBuildSystem #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubmit all commands within the file to prevent OS wide issues with chmod (which turns out doesn't work even if FILE(CHMOD <..>) is used properly, it may be a CMake bug), temporary disable NBL_UPDATE_GIT_SUBMODULE_NO_SEPARATE_SHELL usage, will bring it back in following commit
…ake and update flags.cmake
…list (needs more grouping) - export targets directly to build tree on NBL_3RDPARTY_USE_EXPORT_FROM_BUILD_TREE and use within build system. Add a lot of TODO comments, replace some raw include/link variables with interface libraries & use them, remove old code, fix old bugs & typos
…rate with usual mode (NBL_3RDPARTY_USE_EXPORT_FROM_BUILD_TREE OFF)
…s, stop populating cache if not required, use more generator expressions, split targets into extensions & 3rdparty - add internal functions for hooking them up to build system with respect to build mode, move some options from top level CMakeLists.txt to 3rdparty and use them to create interface targets, add TODO comments & save work
…into newBuildSystem
… few bugs, introduce NBL_3RDPARTY_ENABLE_FOLDER_GROUPING, add utils with recursive search for build system targets, finally compile whole 3rdparty as separate solution excluded from Nabla sources with exported targets saved to file. Self to note, configure time went from around 24 seconds to 8 after refactoring part of CMake 3rdparty codebase with CMake cache loaded, MSVC toolset & VS generator
…riables & configurations, update unix/common.cmake, force DXC's C++ standard to be 17, update .gitignore, write TODO comments
…forces those targets to include like half of Nabla headers within its auto-gen headers I cannot keep it here anymore with new export modes), handle imported Threads target with cmake/init/buildSystem.cmake, remove old generate_nabla_defines custom target and make it a custom command rule, move xxHash256 to Nabla sources into exe directory (it was never a tool because was used with builtins so therefore it's Nabla & derivative targets utility, but still can be used as tool in case). Group Nabla targets into IDE folders. Temporary disable examples & tools - Nabla solution generates correctly with exported 3rdparty imported targets!
…targets to 3rdparty interface, link & include search directories for Nabla & build all builtin resource targets
…because it turns out some of our dependencies call include_directories which is global state and populates directory https://cmake.org/cmake/help/latest/prop_tgt/INCLUDE_DIRECTORIES.html#prop_tgt:INCLUDE_DIRECTORIES property which doesn't get proxied as part of our 3rdparty interface, fix some issues and finally build Nabla with normal mode using new build system, add some TODO comments
…ystem_update_libs Update marked libraries
…ystem Update OpenEXR and spill out its deps
…ystem Fix `newBuildSystem`'s linker errors
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
…king` from root `CMakeLists.txt` Co-authored-by: AnastaZIuk <areklachowicz@gmail.com> Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
…g/Nabla into yas_nbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently not working