Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools_scm for pyproject.toml, setup.cfg and setup.py #185

Merged
merged 67 commits into from
Oct 25, 2024
Merged

Add setuptools_scm for pyproject.toml, setup.cfg and setup.py #185

Changes from 1 commit
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
87ace82
Add setuptools_scm for pyproject.toml, setup.cfg and setup.py
Sep 21, 2024
8737cfd
Also add an init which sets the version based on the setuptools_scm c…
Sep 21, 2024
950931b
See if we can implement a single-source-version approach as in https:…
Sep 23, 2024
d3917a1
Try the fallback_version config item from setuptools_scm. It seems to…
Sep 23, 2024
60d4145
Fix syntax
Sep 23, 2024
8c9bcf3
First, try if we can single source from setup.py for new enough setup…
Sep 23, 2024
07943e3
Try with single version for fallback_version in pyproject.toml and pa…
Sep 23, 2024
580f664
Strip filename of __init__.py file when trying to construct the pypro…
Sep 23, 2024
00ecf53
Forgot to import os.path
Sep 23, 2024
8e29e77
Also except LookupError
Sep 23, 2024
101c40b
leave the setuptools version up to setup.py, as it depends on the pyt…
Sep 23, 2024
593c633
Go back to the last version that passed CI, which specified setuptool…
Sep 24, 2024
bf82ccc
See if this works. Potentially, we can just go for the lowest setupto…
Sep 24, 2024
503e070
Fix syntax error
Sep 24, 2024
43b370f
Fix typo
Sep 24, 2024
26a5a62
Remove specific version requirement so that this also passes with pyt…
Sep 24, 2024
4797e6b
Print filename correctly in error message
Sep 24, 2024
4b80f96
Specify write_to_template specifically if the oldest version of setup…
Sep 24, 2024
c835884
Use scm_dict in setup
Sep 24, 2024
8eb5e25
Make sure to import the fallback version _first_
Sep 24, 2024
b375565
Add missing equal sign
Sep 24, 2024
c7737db
Restructure and also catch other errors when opening the pyproject.to…
Sep 24, 2024
3519d59
Fix typo
Sep 24, 2024
cd318c9
Don't set fallback version in __init__.py anymore. We should have alw…
Sep 24, 2024
5dc180d
Don't print the __version__ in the exception messages, as there is no…
Sep 24, 2024
4a75e41
Merge branch 'setuptools_scm_versioning' of github.com:casparvl/test-…
Sep 24, 2024
ed1d1bd
Fix flake8 complaints
Sep 24, 2024
7a9d16f
Fix flake8 issues. Print version of EESSI as part of the CI pipeline
Sep 24, 2024
b171330
Fix typo
Sep 24, 2024
fffe669
Make CI workflow more verbose for easier debugging
Sep 24, 2024
3f1a984
Enable setuptools_scm debugging output
Sep 24, 2024
610844c
Actually resolve env var
Sep 24, 2024
433c0ca
Make fetch-depth 0, so that setuptools_scm has the full history
Sep 24, 2024
f4a8065
Check for the presence of the version file
Sep 24, 2024
bac5401
Check for the version file _before_ import the version from __init__
Sep 24, 2024
15706fc
We don't seem to be able to convince setuptools_scm version 4 to use …
Sep 24, 2024
a6afd1a
Fix flake8
Sep 24, 2024
0ad305b
Fixed more flake8
Sep 24, 2024
5bca5bb
Merge branch 'main' into setuptools_scm_versioning
casparvl Sep 27, 2024
ddae92c
Merge branch 'setuptools_scm_versioning' of github.com:casparvl/test-…
Oct 1, 2024
9aca8a4
Added CI workflows to check versioning in various ways
Oct 2, 2024
72a3698
Forgot to add the git+ to git+https
Oct 2, 2024
3aec459
Try to debug why the version file doesn't exist...
Oct 2, 2024
3463a78
Make the check independent from the current directory
Oct 2, 2024
5f32c15
Make check independent from current dir
Oct 2, 2024
2bd40a5
For python 3.6, the version file contains 'version' instead of __vers…
Oct 2, 2024
5e98775
Now really: import version instead of __version__ from versionfile fo…
Oct 2, 2024
2921d6d
Also for git+https installs, check if the version file matches the ve…
Oct 2, 2024
f65374e
fix sytnax for github workflow
Oct 2, 2024
d994927
Print setuptools_scm version
Oct 2, 2024
0199051
Only do version check, nothing else
Oct 2, 2024
2b98d1e
Do not-equal-to comparisons on strings. Versions arent numbers
Oct 2, 2024
603b010
More clear reporting on version differences
Oct 2, 2024
49b2710
Make sure to only print the version, nothing else
Oct 2, 2024
fc438ee
Check why these versions could be different
Oct 2, 2024
2c1c3ae
env vars do not carry over between steps. We'll need to get the versi…
Oct 2, 2024
d10afd3
more output to help debugging
Oct 2, 2024
358041f
Don't checkout, we want to test what happens when we pull a tarball f…
Oct 2, 2024
88451e6
Maybe PWD isn't set?
Oct 2, 2024
1452afa
Print the pythonpath so we can check it
Oct 2, 2024
18a6019
We need to re-get the fallback_version because env vars don't carry o…
Oct 2, 2024
fe8094d
Make sure we get the fallback version before changing directory
Oct 2, 2024
15e92d1
Don't need to store the old dir anymore
Oct 2, 2024
5bea644
Add workflow to check the hardcoded fallback version in pyproject.tom…
Oct 2, 2024
d608383
Change where the pyproject.toml is for the grep
Oct 2, 2024
dd05330
Same for CI/run_reframe.sh
Oct 2, 2024
cbefb7a
Fix the fallback version so that it is the latest tagged version
Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't need to store the old dir anymore
  • Loading branch information
Caspar van Leeuwen committed Oct 2, 2024
commit 15e92d1cd9508d2996468ae04f1cc67c61a500a0
1 change: 0 additions & 1 deletion .github/workflows/automatic_versioning.yml
View file
Original file line number Diff line number Diff line change
@@ -90,7 +90,6 @@ jobs:
find $HOME/.local

# make sure we are not in the source directory
work_dir = $PWD
cd $HOME

echo "Checking if file 'eessi/testsuite/_version.py' was generated by setuptools_scm":
Loading