Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated eslint GitHub action #48

Closed
lpil opened this issue Nov 24, 2020 · 0 comments · Fixed by #66
Closed

Remove deprecated eslint GitHub action #48

lpil opened this issue Nov 24, 2020 · 0 comments · Fixed by #66
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers help wanted Extra attention is needed tech

Comments

@lpil
Copy link
Contributor

lpil commented Nov 24, 2020 •
edited
Loading

eslint/github-action has been deprecated.

It recommends using functionality built in to actions/setup-node instead but this functionality is undocumented and there is an issue claiming it is incomplete. actions/setup-node#96

Another option is to remove sufficient JavaScript so that we do not feel the need to use eslint, or to use Prettier formatting instead of style linting.

This is not urgent, opening this issue to ensure this is considered when working on this repo in future.
@lpil lpil added dependencies Pull requests that update a dependency file good first issue Good for newcomers help wanted Extra attention is needed tech labels Dec 3, 2020
lpil added a commit that referenced this issue Dec 10, 2020
@lpil
Swap eslint for prettier
bc4b7e2 
Prettier is closer to rustfmt than eslint, and the eslint action we were
using was deprecated, so I've swapped it out.

This has the nice bonus of not needing errors to be manually fixed,
prettier will automatically do it for us.

Closes: #48
@lpil lpil mentioned this issue Dec 10, 2020
Merged
3 tasks
@lpil lpil closed this as completed in #66 Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers help wanted Extra attention is needed tech
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extra projects, change code styling strategy EmbarkStudios/opensource-website
1 participant
@lpil