Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheet Store #92

Merged
merged 13 commits into from
Apr 7, 2022
Merged

Sheet Store #92

merged 13 commits into from
Apr 7, 2022

Conversation

KyGost
Copy link
Member

@KyGost KyGost commented Apr 5, 2022

Resolves: #34

@KyGost
Copy link
Member Author

KyGost commented Apr 6, 2022

Need to give up on inline schema, use first sheet for schemas

@KyGost
Copy link
Member Author

KyGost commented Apr 6, 2022

Or....
Additional row for column info...?

@KyGost
Copy link
Member Author

KyGost commented Apr 6, 2022

  • add formatting

@KyGost
Copy link
Member Author

KyGost commented Apr 6, 2022

Or....
Additional row for column info...?

This would be an issue for pre-existing sheets... As would separate area for schemas...

@KyGost
Copy link
Member Author

KyGost commented Apr 6, 2022

Simple answer: just turn off type checking...???

@KyGost
Copy link
Member Author

KyGost commented Apr 6, 2022

#38

@KyGost
Copy link
Member Author

KyGost commented Apr 6, 2022

Assume ANY unless column has comment which says data type

@KyGost
Copy link
Member Author

KyGost commented Apr 6, 2022

Encode ColumnDef as TOML using serde

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #92 (e7edcc8) into main (1918f42) will decrease coverage by 60.33%.
The diff coverage is 89.89%.

@@             Coverage Diff             @@
##             main      #92       +/-   ##
===========================================
- Coverage   84.77%   24.43%   -60.34%     
===========================================
  Files         111       80       -31     
  Lines        3861     3196      -665     
===========================================
- Hits         3273      781     -2492     
- Misses        588     2415     +1827     
Impacted Files Coverage Δ
src/result.rs 0.00% <0.00%> (ø)
src/store/mod.rs 22.22% <33.33%> (-11.12%) ⬇️
src/storages/sheet_storage/store.rs 87.17% <87.17%> (ø)
src/storages/sheet_storage/mod.rs 91.66% <91.66%> (ø)
src/storages/sheet_storage/store_mut.rs 96.96% <96.96%> (ø)
src/data/value/mod.rs 20.98% <100.00%> (-56.23%) ⬇️
tests/storages/sheet.rs 100.00% <100.00%> (ø)
src/data/value/methods/unary.rs 0.00% <0.00%> (-100.00%) ⬇️
src/storages/csv_storage/utils.rs 0.00% <0.00%> (-100.00%) ⬇️
src/executor/query/select/join/mod.rs 0.00% <0.00%> (-100.00%) ⬇️
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1918f42...e7edcc8. Read the comment docs.

@KyGost
Copy link
Member Author

KyGost commented Apr 6, 2022

TODO:

  • Clean up
  • Handle errors
  • Implement AlterTable
  • Implement Update, Delete

@KyGost KyGost marked this pull request as ready for review April 7, 2022 02:06
@KyGost
Copy link
Member Author

KyGost commented Apr 7, 2022

Remaining todos:

Good for now though.

@KyGost KyGost merged commit 66bfddb into main Apr 7, 2022
@KyGost KyGost mentioned this pull request Apr 7, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excel file Storage
2 participants