Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Read Operation for SystemMode #2046

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Conversation

hcarter-775
Copy link
Contributor

Description of Change

set a field in the case of out of order handlers instead of doing a read request, and run the handler later.

Summary of Completed Tests

Copy link

github-actions bot commented Apr 3, 2025

Channel deleted.

Copy link

github-actions bot commented Apr 3, 2025

Test Results

   66 files    420 suites   0s ⏱️
2 164 tests 2 164 ✅ 0 💤 0 ❌
3 685 runs  3 685 ✅ 0 💤 0 ❌

Results for commit f6736f6.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 3, 2025

File Coverage
All files 84%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 50%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 86%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against f6736f6

@hcarter-775 hcarter-775 force-pushed the remove-system-mode-read branch from 9f23b9c to f6736f6 Compare April 3, 2025 19:51
Copy link
Contributor

@ctowns ctowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Harrison! I left a reply on the open comment and I'm fine with either option, thanks for getting this up so quickly!

@hcarter-775 hcarter-775 merged commit 9f45e34 into main Apr 4, 2025
11 checks passed
@hcarter-775 hcarter-775 deleted the remove-system-mode-read branch April 4, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants