Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): use husky for pre-commit #19

Merged
merged 8 commits into from
Jan 8, 2020

Conversation

francisfuzz
Copy link
Contributor

This PR updates package.json to include husky as a devDependency, moving the precommit step from scripts to husky as suggested by their documentation.

cc: @jclem for review

@jclem
Copy link
Contributor

jclem commented Jan 8, 2020

@francisfuzz Can you remove the change to dist/index.js in this? Then should be good to go.

@francisfuzz
Copy link
Contributor Author

Can you remove the change to dist/index.js in this? Then should be good to go.

I'll do that, will follow up here when it's finished 👌

@francisfuzz
Copy link
Contributor Author

@jclem - While I'm totally up to make that change, I'm wondering why you don't want that newly updated dist/index.js file there? Is it because the changes in scope are only related to husky rather than source file itself?

As an aside -- I'd like to figure out what's happening on my local machine that's actually hardcoding values of my local copy into the dist/index.js upon compilation of the Typescript source file. Not sure what's happening there.

@jclem
Copy link
Contributor

jclem commented Jan 8, 2020

@francisfuzz I think it's something with your local setup—when I reproduce this PR on my own branch, dist/index.js isn't changed (which it shouldn't be, since husky wouldn't be required in the distribution build for this action).

@jclem
Copy link
Contributor

jclem commented Jan 8, 2020

Ugh, I tried fixing it but can't get rid of the newline.

@jclem jclem merged commit 5bc9a17 into actions:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants