-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): use husky for pre-commit #19
Conversation
@francisfuzz Can you remove the change to |
I'll do that, will follow up here when it's finished 👌 |
@jclem - While I'm totally up to make that change, I'm wondering why you don't want that newly updated As an aside -- I'd like to figure out what's happening on my local machine that's actually hardcoding values of my local copy into the |
@francisfuzz I think it's something with your local setup—when I reproduce this PR on my own branch, |
Ugh, I tried fixing it but can't get rid of the newline. |
This PR updates
package.json
to includehusky
as adevDependency
, moving the precommit step fromscripts
tohusky
as suggested by their documentation.cc: @jclem for review