Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vm.runInNewContext to run script #21

Closed
wants to merge 3 commits into from
Closed

Use vm.runInNewContext to run script #21

wants to merge 3 commits into from

Conversation

jclem
Copy link
Contributor

@jclem jclem commented Jan 10, 2020 •
edited
Loading

Rather than using a function constructor, use vm.runInNewContext, as it feels a bit less hacky.

@jclem jclem mentioned this pull request Jan 10, 2020
Closed
@jclem
Copy link
Contributor Author

jclem commented Jan 10, 2020 •
edited
Loading

Ah, bummer. console.log won't work in this context, but I think that's fixed if we explicitly pass it in.

@jclem jclem force-pushed the use-vm-context branch 12 times, most recently from 0645543 to 3dee935 Compare January 10, 2020 12:49
@jclem jclem force-pushed the master branch 2 times, most recently from 3c186bc to 8e6ec0e Compare February 13, 2020 19:17
@jclem jclem force-pushed the master branch 4 times, most recently from 76b2013 to 38e3ffe Compare February 27, 2020 22:52
@jclem
Copy link
Contributor Author

jclem commented Feb 28, 2020

Going to close this, as new AsyncFunction has been working well.

@jclem jclem closed this Feb 28, 2020
@jclem jclem deleted the use-vm-context branch February 28, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jclem