-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read version from use-node-version key of .npmrc #1149
base: main
Are you sure you want to change the base?
Conversation
@aparnajyothi-y for visibility |
@aparnajyothi-y , gentle bump on this :) |
We would love to be able to drop |
@aparnajyothi-y, bumping this again :) I'd love to get this in if my changes look good to you |
[Copilot is generating a summary...] Marge comment |
@aparnajyothi-y, seems like you're quite busy. Is there someone else I should be seeking a review from? |
I'd love to see this too! @aparnajyothi-y or @priya-kinthali, any chance we can nudge you to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6f7d311
to
c9b99bb
Compare
c9b99bb
to
b0f1a15
Compare
@aparnajyothi-y or @priya-kinthali, any chance we can nudge you to review this PR? If not, can you suggest another reviewer with bandwidth? |
Hi @aparnajyothi-y or @priya-kinthali, could I trouble you to review this PR? I'd greatly appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the below comments are why maintainers are staying away from approving this pr. i can take another crack in another pr if you don't have time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe instead install @types/ini
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ini does not have any dependencies so it shouldn't change the package-lock.json i believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it normal that this number of changes are made? seems like quite a red flag
Hello Everyone, Thank you for this pull request. We are looking into it and get back to you once we have some feedback on this :) |
@mcevoypeter - I forked your PR to confirm what @PeterCardenas commented. Change to the lock file and dist directory are much more reasonable: https://github.com/actions/setup-node/pull/1253/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519. All I did was restore the lockfile, add @types/init and rebuild. Feel free to cherry pick the last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description:
Add support for determining the Node version from the
use-node-version
key of.npmrc
as described in the PNPM docs.Related issue:
Resolves #1130
Check list: